Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Temps Notification/Alert #131

Closed
speedrapide10 opened this issue Aug 24, 2024 · 7 comments
Closed

[Feature Request] Temps Notification/Alert #131

speedrapide10 opened this issue Aug 24, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@speedrapide10
Copy link

Hello,

Could you please add temps sensors Notification/Alert.

Thank you for your great work 🦾

@henrygd henrygd added the enhancement New feature or request label Aug 24, 2024
@steveiliop56
Copy link
Contributor

@henrygd I can try that too. I may be able to do it.

@henrygd
Copy link
Owner

henrygd commented Sep 17, 2024

@steveiliop56 You can give it a go if you want, but it's going to be fairly complicated and I can't guarantee that I'll merge.

It will probably require new UI components and updates to the alerts collection. If you have ideas on implementation then we can discuss it further.

Adding time thresholds for alerts (#93) is near the top of my list, and I was going to see if I could add this in the same release. But it's likely going to be a few weeks until I can get around to because I need to work on a project for a client 😑

@steveiliop56
Copy link
Contributor

No problem, I will try to make a solid base for the feature so you can customize/fix it as much as you want. I believe it's going to be some copy pasta from the other notifications you have right?

@henrygd
Copy link
Owner

henrygd commented Sep 17, 2024

It depends on the implementation. If the alert is based on a single temperature and triggers if any sensor exceeds that temperature, then it will be pretty easy to add. I could probably add it and release it this week.

If we want to let the user choose which sensors to monitor and set custom thresholds for each sensor, that's going to require more work on both the front end and back end.

My thought is that most people would want the latter, but maybe I'm wrong.

@steveiliop56
Copy link
Contributor

I was thinking we set an 80 C threshold for everything because if anything goes over 80 degrees on your machine I think you have an issue lol.

@steveiliop56
Copy link
Contributor

@henrygd unfortunately I don't have any time to work on this feature, sorry. You can take over since you will get it done faster than me lol.

@henrygd
Copy link
Owner

henrygd commented Oct 16, 2024

Added in 0.6.0.

Let me know if you have any issues with it.

@henrygd henrygd closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants