Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use abandonwares noble fork #2

Open
zilluss opened this issue Jun 2, 2019 · 9 comments
Open

Use abandonwares noble fork #2

zilluss opened this issue Jun 2, 2019 · 9 comments

Comments

@zilluss
Copy link

zilluss commented Jun 2, 2019

Apparently, noble is not maintained anymore (See noble/node-bluetooth-hci-socket#84). I noticed this when I tried to install nubli-homebridge on my Raspberry 3 B, which failed to build on Node 10. I would suggest to switch to @abandonware/noble, which appears to be a well maintained fork.

@henry-spanka
Copy link
Owner

Hi,
looks reasonable. Can you install nubli if you replace the package vendor in package.json?

@zilluss
Copy link
Author

zilluss commented Jun 3, 2019

Yes, I just tried it. I also tried building the unmodified checkout to confirm the build error. noble 1.9.1 fails with:
binding.target.mk:99: recipe for target 'Release/obj.target/binding/src/BluetoothHciSocket.o' failed

Changing to @abandonware/noble builds just fine. I had to bump the version to 1.9.2-2 though.

@zilluss
Copy link
Author

zilluss commented Jun 3, 2019

While it does compile, it doesn't work quite right (yet), presumably related to this issue:
abandonware/noble#15
I was able to pair with my lock (although only with bridge=false). But any operation that requires pairing won't work. I will post an update once I got everything running using Node 10 and Linux/Raspberry.

@henry-spanka
Copy link
Owner

Okay. I am currently getting my hands on the new ODROID N2. I will probably switch to Node 10/11 too and will try to use abandonware's fork instead.

@henry-spanka
Copy link
Owner

I couldn't get it working either. I think we must wait until the issue is resolved in the upstream repo. Alternatively you can run node 8 in a docker container, that's what I did now.

@zilluss
Copy link
Author

zilluss commented Aug 30, 2020

I tested nubli on Node 12 with @abandonware/noble and it works fine (using an USB BT dongle). May I create a PR that uses the abandonware package instead?

@henry-spanka
Copy link
Owner

Please do. Unfortunately I don't have a Nuki smart lock anymore so I can not test it.

@muratcorlu
Copy link

@zilluss I couldn't see any PR. Are you still able to use it? Does it also work with Node 14?

@zilluss
Copy link
Author

zilluss commented May 6, 2021

I didn't use this plugin in a while, I will test it and get back at you. The problem at the time was that I had to create a PR at the noble fork with additions to the typescript bindings, which are merged by now. So hopfefully using the abandonware fork should be as easy as replacing a line in the package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants