-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use abandonwares noble fork #2
Comments
Hi, |
Yes, I just tried it. I also tried building the unmodified checkout to confirm the build error. noble 1.9.1 fails with: Changing to @abandonware/noble builds just fine. I had to bump the version to 1.9.2-2 though. |
While it does compile, it doesn't work quite right (yet), presumably related to this issue: |
Okay. I am currently getting my hands on the new ODROID N2. I will probably switch to Node 10/11 too and will try to use abandonware's fork instead. |
I couldn't get it working either. I think we must wait until the issue is resolved in the upstream repo. Alternatively you can run node 8 in a docker container, that's what I did now. |
I tested nubli on Node 12 with @abandonware/noble and it works fine (using an USB BT dongle). May I create a PR that uses the abandonware package instead? |
Please do. Unfortunately I don't have a Nuki smart lock anymore so I can not test it. |
@zilluss I couldn't see any PR. Are you still able to use it? Does it also work with Node 14? |
I didn't use this plugin in a while, I will test it and get back at you. The problem at the time was that I had to create a PR at the noble fork with additions to the typescript bindings, which are merged by now. So hopfefully using the abandonware fork should be as easy as replacing a line in the package.json. |
Apparently, noble is not maintained anymore (See noble/node-bluetooth-hci-socket#84). I noticed this when I tried to install nubli-homebridge on my Raspberry 3 B, which failed to build on Node 10. I would suggest to switch to @abandonware/noble, which appears to be a well maintained fork.
The text was updated successfully, but these errors were encountered: