Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash onCancel #826

Closed
looweex opened this issue May 27, 2024 · 1 comment · Fixed by #827
Closed

crash onCancel #826

looweex opened this issue May 27, 2024 · 1 comment · Fixed by #827

Comments

@looweex
Copy link

looweex commented May 27, 2024

use the datepicker as below
<DatePicker
modal
mode="time"
open={show}
date={date}
theme="dark"
onConfirm={(date) => {
setShow(false)
setDate(date)
}}
onCancel={() => {
setShow(false)
}}
/>

when i click Cancel button, there is an error

<img width="410" alt="" src="https://github.com/henninghall/react-native-date-picker/assets/47051545/36bf4e0c-f0e9-4a20-82cf-194993b94b03"

my env info:
System:
OS: macOS 14.1.2
CPU: (12) arm64 Apple M2 Max
Memory: 314.64 MB / 32.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 21.7.3
path: /opt/homebrew/bin/node
Yarn:
version: 1.22.21
path: /opt/homebrew/bin/yarn
npm:
version: 10.5.0
path: /opt/homebrew/bin/npm
Watchman:
version: 2024.04.15.00
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.15.2
path: /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.0
- iOS 17.0
- macOS 14.0
- tvOS 17.0
- watchOS 10.0
Android SDK: Not Found
IDEs:
Android Studio: 2023.2 AI-232.10227.8.2321.11479570
Xcode:
version: 15.0.1/15A507
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.9
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.73.0
wanted: 0.73.0
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false

@henninghall
Copy link
Owner

henninghall commented May 28, 2024

Thanks for the PR @rajdevkar, the fix is released in version 5.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants