feat: force sso login #1191
Merged
feat: force sso login #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 10, 2024 23:19
NiclasNorin
requested changes
Dec 11, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the login and logout functionality, including the integration of Single Sign-On (SSO) with MiniOrange, as well as several enhancements to the login process. The changes introduce new classes, update existing ones, and rename some files for better clarity.
SSO Integration and Configuration:
MiniOrangeConfigandMiniOrangeConfigInterfaceto manage MiniOrange SSO settings and check if SSO login is required. (library/Admin/Integrations/MiniOrange/Config/MiniOrangeConfig.php[1]library/Admin/Integrations/MiniOrange/Config/MiniOrangeConfigInterface.php[2]RequireSsoLoginclass to handle redirection to the SSO provider if SSO login is required. (library/Admin/Integrations/MiniOrange/RequireSsoLogin.phplibrary/Admin/Integrations/MiniOrange/RequireSsoLogin.phpR1-R81)Login and Logout Enhancements:
DoNotHaltLogoutWhenNonceIsMissingto handle logouts without nonce verification. (library/Admin/Login/DoNotHaltLogoutWhenNonceIsMissing.phplibrary/Admin/Login/DoNotHaltLogoutWhenNonceIsMissing.phpR1-R48)LogUserLoginTimeclass to track user login times and display them in the admin user list. (library/Admin/Login/LogUserLoginTime.phplibrary/Admin/Login/LogUserLoginTime.phpR1-R117)RegisterLoginLogoutOptionsPage. (library/Admin/Login/RegisterLoginLogoutOptionsPage.phplibrary/Admin/Login/RegisterLoginLogoutOptionsPage.phpR1-R33)File Renaming for Clarity:
EnqueueStylestoEnqueueLoginScreenStylesfor better clarity. (library/Admin/Login/EnqueueLoginScreenStyles.phplibrary/Admin/Login/EnqueueLoginScreenStyles.phpL9-R9)ChangeLogotypeDatatoSetLoginScreenLogotypeData. (library/Admin/Login/SetLoginScreenLogotypeData.phplibrary/Admin/Login/SetLoginScreenLogotypeData.phpL8-R8)Additional Changes:
BaseControllerto modify the login and logout URLs. (library/Controller/BaseController.phplibrary/Controller/BaseController.phpL335-R336)Bootstrapfile. (library/Bootstrap.phplibrary/Bootstrap.phpR112)These changes collectively improve the login/logout process, integrate SSO capabilities, and enhance the overall user experience.