Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of BaseEstimator and mixins for high-level analysis algorithms #535

Merged
merged 8 commits into from
Apr 7, 2020

Conversation

Markus-Goetz
Copy link
Member

Description

This PR introduces a BaseEstimator base class for high-level algorithms. Furthermore, it implements mixins for clustering, classification and regression algorithms. Existing algorithms have been adjusted to make use of the new classes.

Issue/s resolved: #399

Changes proposed:

  • BaseEstimator class
  • Mixins for regression, classification and clustering algorithms
  • Adjustments of existing algorithms.

Type of change

Remove irrelevant options:

  • New feature (non-breaking change which adds functionality)
  • Documentation update

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

yes - unified get_params and set_params for high-level algorithms

@Markus-Goetz Markus-Goetz requested review from Cdebus, coquelin77 and ClaudiaComito and removed request for Cdebus April 7, 2020 11:14
@Markus-Goetz Markus-Goetz added API Anything relating the API enhancement New feature or request labels Apr 7, 2020
coquelin77
coquelin77 previously approved these changes Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #535 into master will increase coverage by 0.10%.
The diff coverage is 90.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
+ Coverage   96.28%   96.38%   +0.10%     
==========================================
  Files          75       75              
  Lines       14541    14481      -60     
==========================================
- Hits        14001    13958      -43     
+ Misses        540      523      -17     
Impacted Files Coverage Δ
heat/core/base.py 76.66% <76.66%> (ø)
heat/regression/tests/test_lasso.py 90.56% <90.56%> (ø)
heat/regression/lasso.py 92.15% <92.15%> (ø)
heat/__init__.py 100.00% <100.00%> (ø)
heat/cluster/kmeans.py 90.90% <100.00%> (+2.02%) ⬆️
heat/cluster/spectral.py 93.33% <100.00%> (+21.90%) ⬆️
heat/cluster/tests/test_kmeans.py 89.58% <100.00%> (+5.20%) ⬆️
heat/cluster/tests/test_spectral.py 89.36% <100.00%> (+3.25%) ⬆️
heat/core/__init__.py 100.00% <100.00%> (ø)
heat/naive_bayes/gaussianNB.py 93.50% <100.00%> (-0.09%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5782fe1...4764b68. Read the comment docs.

@coquelin77 coquelin77 merged commit 7a6e29f into master Apr 7, 2020
@coquelin77 coquelin77 deleted the features/399-base-estimator branch April 7, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Anything relating the API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce BaseEstimator
2 participants