Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend kwargs out, where to all binary operations #958

Closed
ClaudiaComito opened this issue Apr 6, 2022 · 3 comments
Closed

Extend kwargs out, where to all binary operations #958

ClaudiaComito opened this issue Apr 6, 2022 · 3 comments
Labels
array API enhancement New feature or request good first issue Good for newcomers stale

Comments

@ClaudiaComito
Copy link
Contributor

Related
#870

Feature functionality
As per #945, it is possible to pass a condition to _operations.__binary_op via the kwarg where. This feature is available in ht.divide. Extend feature to all operations calling _operations.__binary_op, if the numpy API calls for it.

@ClaudiaComito ClaudiaComito added enhancement New feature or request good first issue Good for newcomers API Anything relating the API GSoC labels Apr 6, 2022
@ClaudiaComito ClaudiaComito added this to the Repo Clean-Up milestone Jul 31, 2023
@ClaudiaComito ClaudiaComito removed the GSoC label Aug 7, 2023
@ClaudiaComito ClaudiaComito removed this from the Repo Clean-Up milestone Aug 7, 2023
@ClaudiaComito ClaudiaComito added array API and removed API Anything relating the API labels Aug 7, 2023
@ClaudiaComito
Copy link
Contributor Author

This is still open. Just to clarify, here's what needs to be done.

  • [] find all heat functions calling _operations.__binary_op() (mostly in the arithmetics module)
  • [] compare the heat API of those functions with the Python array API standard
  • [] enable keyword arguments out and where for those binary operations that require it (as per array API standard)
  • [] expand documentation for the modified functions (if API diverges from the equivalent numpy function, please point it out in the docs)
  • [] expand tests

This should be a relatively small change applied to a number of functions.


Reviewed within #1109

Copy link
Contributor

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Jun 10, 2024
Copy link
Contributor

This issue was closed because it has been inactive for 60 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
array API enhancement New feature or request good first issue Good for newcomers stale
Projects
None yet
Development

No branches or pull requests

1 participant