Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logical._sanitate_close_input should check shapes, and broadcast before redistributing #457

Closed
ClaudiaComito opened this issue Jan 20, 2020 · 1 comment
Closed

logical._sanitate_close_input should check shapes, and broadcast before redistributing #457

ClaudiaComito opened this issue Jan 20, 2020 · 1 comment
Assignees
@ClaudiaComito
Labels
redistribution Related to distributed tensors
Milestone
Repo Clean-Up

Comments

@ClaudiaComito
Copy link
Contributor

Feature functionality
Currently, the input tensors x, y for logical.isclose get sanitized within logical._sanitize_close_input. Part of the job is to redistribute y based on the split direction of x if y.split != x.split.

Problem: x and y must be broadcastable, and if y.split != x.split, broadcasting must happen before redistributing along the new split axis.
@ClaudiaComito ClaudiaComito added the redistribution Related to distributed tensors label Jan 20, 2020
@ClaudiaComito ClaudiaComito self-assigned this Jan 20, 2020
@ClaudiaComito ClaudiaComito changed the title logical._sanitate_close_input should check shapes and broadcast before redistributing logical._sanitate_close_input should check shapes, and broadcast before redistributing Jan 20, 2020
@ClaudiaComito ClaudiaComito mentioned this issue Jan 20, 2020
Merged
3 tasks
@ClaudiaComito ClaudiaComito mentioned this issue Feb 5, 2020
Merged
4 tasks
@ClaudiaComito ClaudiaComito added this to the Repo Clean-Up milestone Jul 31, 2023
@ClaudiaComito
Copy link
Contributor Author

Closing this issue as addressing #379 will solve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ClaudiaComito ClaudiaComito

Labels
redistribution Related to distributed tensors
Projects
None yet
Milestone
Repo Clean-Up
Development

No branches or pull requests
1 participant
@ClaudiaComito