Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automated quoting introduced in v0.24.0 causing regressions #142

Closed
pdeva opened this issue Apr 13, 2023 · 3 comments
Closed

automated quoting introduced in v0.24.0 causing regressions #142

pdeva opened this issue Apr 13, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@pdeva
Copy link

pdeva commented Apr 13, 2023 •
edited
Loading

this is related to the change introduced by this PR:
#138

when vals is used with helm-secrets, this is now resulting in values being stored with quotes in k8s files where quotes were not expected. This is then causing the relevant apps accessing those values to break.

An example is when things like pem certificates are put in k8s secrets and referneced via vals in helm chart configs. This change puts quotes around those certificate contents causing the app trying to read the certificate to break.

please atleast provide a flag to disable this automatic quoting.
@pdeva pdeva changed the title automated quoting in values causing breakage everywhere automated quoting introduced in v0.24.0 values causing breakage everywhere Apr 13, 2023
@pdeva pdeva changed the title automated quoting introduced in v0.24.0 values causing breakage everywhere automated quoting introduced in v0.24.0 values causing regressions Apr 13, 2023
@pdeva pdeva changed the title automated quoting introduced in v0.24.0 values causing regressions automated quoting introduced in v0.24.0 causing regressions Apr 13, 2023
@stoned stoned mentioned this issue Apr 16, 2023
Merged
1 task
@stoned
Copy link
Contributor

stoned commented Apr 16, 2023

I have submitted jkroepke/helm-secrets#362 to hopefully address this issue.

@yxxhero yxxhero added the enhancement New feature or request label Apr 17, 2023
@yxxhero yxxhero closed this as completed Apr 17, 2023
@yxxhero
Copy link
Member

yxxhero commented Apr 17, 2023

see: #144

@mdfaizsiddiqui
Copy link

Hey @stoned @yxxhero, Its been a while this fix has been merged but I don't see a new release created for helm-secret, can you help me with that?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stoned @pdeva @yxxhero @mdfaizsiddiqui