Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more macros #70

Closed
michaelbukachi opened this issue May 27, 2020 · 6 comments
Closed

Support more macros #70

michaelbukachi opened this issue May 27, 2020 · 6 comments

Comments

@michaelbukachi
Copy link
Contributor

Hello,
Nice library! I use it in a couple of projects.
Are there plans to add more macros to support more bootstrap 4 components?
I have a couple in mind and would to do a PR or two.

@greyli
Copy link
Member

greyli commented May 30, 2020

Sure thing, what's your plan? It's better to discuss it first, since some components may do not need to write a macro.

@michaelbukachi
Copy link
Contributor Author

Let's discuss it first. Yeah not all components need macros. I'm thinking of starting with complex components which would need macros. For instance tables. Maybe something along the lines of

render_table(titles, data, bordered=False, ....)

Since you've added pagination already, I think it makes sense to proceed to tables.

@greyli
Copy link
Member

greyli commented May 31, 2020

Yeah, the render_table makes sense.

@michaelbukachi
Copy link
Contributor Author

Awesome. I think I can start working on the render_table macro.

@WolfgangFahl
Copy link

The example already shows this but no content? What's needed to close this? See #113

@greyli
Copy link
Member

greyli commented Jan 10, 2021

Closing for now, feel free to make a PR/issue for new macro.

@greyli greyli closed this as completed Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants