Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2.3.2 of Flask breaks examples? #317

Closed
PanderMusubi opened this issue Sep 18, 2023 · 3 comments
Closed

Version 2.3.2 of Flask breaks examples? #317

PanderMusubi opened this issue Sep 18, 2023 · 3 comments
Assignees
@PanderMusubi
Labels
dependencies Pull requests that update a dependency file

Comments

@PanderMusubi
Copy link
Collaborator

This line https://github.com/helloflask/bootstrap-flask/blame/02093bf2f6fb415f7a38ba5866e3bf915c1efe2b/requirements/examples.txt#L14 is that the cause of this error:

File "/var/www/html/app.py", line 140, in <module>
  @app.before_first_request
AttributeError: 'Flask' object has no attribute 'before_first_request'

Solution can be to follow the advice of https://stackoverflow.com/questions/73570041/flask-deprecated-before-first-request-how-to-update
@PanderMusubi PanderMusubi added the dependencies Pull requests that update a dependency file label Sep 18, 2023
@PanderMusubi
Copy link
Collaborator Author

Fixed in #320

@PanderMusubi
Copy link
Collaborator Author

PanderMusubi commented Sep 19, 2023 •
edited
Loading

Merging the PR will enable the live examples demo for HEAD. I will share the URL in https://github.com/helloflask/bootstrap-flask/blob/master/examples/README.rst once it runs again.

@greyli greyli removed their assignment Sep 21, 2023
@PanderMusubi
Copy link
Collaborator Author

Later improvement needed as noted in #320 (comment)

@PanderMusubi PanderMusubi self-assigned this Sep 22, 2023
@greyli greyli closed this as completed Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PanderMusubi PanderMusubi

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PanderMusubi @greyli