Add option to control overtype of closing pairs #10878
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verte-zerg
changed the title
|
Hi, I basically implemented this same solution when I found your PR.
|
verte-zerg
force-pushed
the
auto-closing-overtype
branch
from
26cfb48
to
ceceaba
Compare
dlordi
approved these changes
Jun 13, 2024
dlordi
approved these changes
Jun 13, 2024
verte-zerg
force-pushed
the
auto-closing-overtype
branch
from
ceceaba
to
ae19dd1
Compare
|
The PR was rebased |
verte-zerg
force-pushed
the
auto-closing-overtype
branch
from
ae19dd1
to
69605fa
Compare
verte-zerg
force-pushed
the
auto-closing-overtype
branch
from
69605fa
to
b772e9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
auto-closing-overtypeto control overtype of closing pairs (default: true)Closes: #9595
I've implemented the feature and only then realized that another PR, which is fixing the issue, already exists. However, it looks like there have been no changes for a month.
The PR doesn't break compatibility with old configs.