-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helix thread 'main" panicked while trying to launch a debug session. #8625
Comments
looks like lldb-vscode(they just changed the name to lldb-dap last week) doesn't send the full breakpoint back if the breakpoint is from the editor because of sourcemaps: https://github.com/llvm/llvm-project/blob/a13696fd8490f67b6ad119fcb6fda20e1fd3a089/lldb/tools/lldb-dap/lldb-dap.cpp#L528-L533 you can see it in the request here that it is missing some info specifically line is what causes the crash:
this is because currently in the code when we get a changed event we reset everything to what comes in the request: helix/helix-view/src/handlers/dap.rs Lines 230 to 231 in ef1f4f3
the spec doesnt really say how we are supposed to handle breakpoint changed events so best bet is too look at what vscode does, I think what we probably want to do is only set things that are some when we get a changed event, then we wouldn't need to unwrap the line and it just wouldn't get set |
I've looked into it, but I don't know know typescript, or javascript for that matter, but the comments were quite helpful, they talk about how the events hare handled and in which order they are expected, I'm not sure if this is of any help but just in case this is where I've found it. |
This comment was marked as spam.
This comment was marked as spam.
Any news on this?? I've just changed Neovim for Helix and this is the only thing I'm still missing |
Fixed by #9632 |
Thanks very much this is a big upgrade for my current workflow <3 |
Summary
this is the error message that I get when I try to launch a debugging session on MacOS Sonoma 14.0 using the latest version of Helix, 23.10, using the latest version of LLDB, having built LLDB-MI, and Having hx --health recognizing everything for C/Cpp dev Helix is truly the best code editor out there, but both the documentation for configuring the debugger, and actually tring to using it is poor at best, I would gladly be willing to help if i could receive some guidance on how the thing work, because so far it's been quite frustrating to try to debug in Helix, I know it's experimental. but I think the debugger could improve widely if we had access on better documentation on how to use it to give good feedback on what is working and what is not working :
Reproduction Steps
I tried this:
I expected this to happen:
launching a debugging session.
Instead, this happened:
Just in case here is the file I was using :
here is the flag used to compile the program :
the version of cc used is :
Helix log
~/.cache/helix/helix.log
Platform
MacOS Sonoma 14.0
Terminal Emulator
Iterm2 v3.4
Helix Version
helix 23.10 (f6021dd)
The text was updated successfully, but these errors were encountered: