Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language servers fail if one is missing #8361

Closed
QaidVoid opened this issue Sep 23, 2023 · 4 comments · Fixed by #8374
Closed

Language servers fail if one is missing #8361

QaidVoid opened this issue Sep 23, 2023 · 4 comments · Fixed by #8374
Assignees
Labels
A-language-server Area: Language server client C-bug Category: This is a bug

Comments

@QaidVoid
Copy link

Summary

If one of the language server from language-servers list is missing, none of the language servers work.

Reproduction Steps

Configure multiple language servers

~/.config/helix/languages.toml
[[language]]
name = "jsx"
auto-format = true
language-servers = ["typescript-language-server", "biome", "emmet"]
formatter = { command = "biome", args = ["format", "--stdin-file-path", "test.jsx"]}

Expected behavior:
The existing language server should work even if other language servers are missing.

What happened:
The language server process is spawned but it doesn't work.

Helix log

No response

Platform

Linux

Terminal Emulator

foot version: 1.15.3

Helix Version

helix 23.05 (1c88432)

@QaidVoid QaidVoid added the C-bug Category: This is a bug label Sep 23, 2023
@kirawi kirawi added the A-helix-term Area: Helix term improvements label Sep 23, 2023
@woojiq
Copy link
Contributor

woojiq commented Sep 23, 2023

I also faced this problem. This is fixed here #7900, specifically in this commit 1bd0410. Although it is not yet merged.

@gabydd
Copy link
Member

gabydd commented Sep 23, 2023

We might want to extract that fix to a seperate pr so we can get it into the coming release

@woojiq
Copy link
Contributor

woojiq commented Sep 23, 2023

Sure, do this?

@the-mikedavis
Copy link
Member

I think we want both changes from #7900 anyways but I agree - could you pull that commit out to a separate PR? It's pretty distinct from the pull diagnostics changes and I'd prefer to have those be cleanly separate in the commit history

@the-mikedavis the-mikedavis added A-language-server Area: Language server client and removed A-helix-term Area: Helix term improvements labels Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-server Area: Language server client C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants