Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix crashes while editing yaml #7894

Closed
kharf opened this issue Aug 10, 2023 · 5 comments
Closed

Helix crashes while editing yaml #7894

kharf opened this issue Aug 10, 2023 · 5 comments
Labels
C-bug Category: This is a bug

Comments

@kharf
Copy link

kharf commented Aug 10, 2023

Summary

I have been using Helix 23.05 for quite some time and been editing the same yamls over and over again, but today Helix just crashes as soon as I want to edit some of the yamls (not all).
I don't have the yaml-language-server installed. When I installed it today, I could actually edit the files, but only sometimes.

I could reproduce it on of my public repositories: https://github.com/kharf/flux-k8s-stack as described below.

An example where helix doesn't crash is the catalog/keda/releases.yaml

Reproduction Steps

I tried this:

  1. cd flux-k8s-stack
  2. hx .
  3. <space>f checkov.yaml
  4. i and try to edit the file (any other mutation also crashes)

I expected this to happen:
to be able to edit the file

Instead, this happened:
helix crashes:
1 [1] 109128 segmentation fault (core dumped) hx . 2 framework: %

Helix log

~/.cache/helix/helix.log
2023-08-10T09:55:41.443 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T09:56:39.192 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T09:57:50.266 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T09:58:00.933 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T09:58:06.061 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T10:01:46.123 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T10:01:54.168 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T10:02:30.949 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T10:02:37.030 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T10:05:19.870 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T10:07:06.045 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T10:07:17.146 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T10:07:33.575 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T10:08:11.966 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T10:08:24.717 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T10:08:31.397 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T10:10:20.619 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T10:13:38.568 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T10:16:16.447 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }
2023-08-10T10:17:48.666 helix_view::editor [ERROR] Failed to initialize the LSP for `source.yaml` { cannot find binary path }

Platform

Linux NixOS 23.05.20230807.011567f (Stoat) x86_64

Terminal Emulator

alacritty 0.12.2

Helix Version

helix 23.05 (7f5940b)

@kharf kharf added the C-bug Category: This is a bug label Aug 10, 2023
@kharf kharf changed the title Helix crashes while editing yaml without the yaml-language-server installed Helix crashes while editing yaml Aug 10, 2023
@CptPotato
Copy link
Contributor

CptPotato commented Aug 10, 2023

Is it possible for you to try with the latest master branch?

I'm unable to reproduce the issue, so it might have been fixed in the meantime (by #7621 maybe?).

@kharf
Copy link
Author

kharf commented Aug 10, 2023

Is it possible for you to try with the latest master branch?

I'm unable to reproduce the issue, so it might have been fixed in the meantime (by #7621 maybe?).

Sure I will try. Somehow I didnt think about trying it.

@pascalkuthe
Copy link
Member

This is either bug in the grammar or #7227

@kharf
Copy link
Author

kharf commented Aug 10, 2023

sorry for the issue.
I couldnt reproduce it with helix 23.05 (57f093d)

Should I close it?

Thanks for the responses!

@pascalkuthe
Copy link
Member

Yeah I think this was almost certainly fixed by #7227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

3 participants