Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad verilog grammar source #7260

Closed
blt-r opened this issue Jun 6, 2023 · 1 comment · Fixed by #7262
Closed

Bad verilog grammar source #7260

blt-r opened this issue Jun 6, 2023 · 1 comment · Fixed by #7262
Labels
A-language-support Area: Support for programming/text languages E-easy Call for participation: Experience needed to fix: Easy / not much

Comments

@blt-r
Copy link
Contributor

blt-r commented Jun 6, 2023

In languages.toml there is

source = { git = "https://github.com/andreytkachenko/tree-sitter-verilog", rev = "514d8d70593d29ef3ef667fa6b0e504ae7c977e3" }

But in https://github.com/andreytkachenko/tree-sitter-verilog there is no commit with 514d8d70593d29ef3ef667fa6b0e504ae7c977e3 hash. GitHub shows that the commit "does not belong to any branch on this repository, and may belong to a fork outside of the repository." (andreytkachenko/tree-sitter-verilog@514d8d7), which also might mean that it was forced-pushed over.

Also why @andreytkachenko's fork is being used, instead of the tree-sitter/tree-sitter-verilog?

@gabydd
Copy link
Member

gabydd commented Jun 6, 2023

seems like we can switch to tree-sitter repo: as tree-sitter/tree-sitter-verilog#56 seems to be merged which I assume is why we where using the fork

@gabydd gabydd added E-easy Call for participation: Experience needed to fix: Easy / not much A-language-support Area: Support for programming/text languages labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages E-easy Call for participation: Experience needed to fix: Easy / not much
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants