Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not exit with an error code if language server fails to shut down #7211

Closed
justinlovinger opened this issue Jun 2, 2023 · 1 comment · Fixed by #7449
Closed

Do not exit with an error code if language server fails to shut down #7211

justinlovinger opened this issue Jun 2, 2023 · 1 comment · Fixed by #7449
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@justinlovinger
Copy link

I use ltex-ls for commit messages. With the latest Helix, commits will sometimes fail because I close the commit editor before ltex-ls started up. Aside from this example, I see no good reason a process calling Helix will need to treat a language server failing to gracefully shut down as an error in the file edited by Helix.

@justinlovinger justinlovinger added the C-enhancement Category: Improvements label Jun 2, 2023
@kirawi kirawi added the A-helix-term Area: Helix term improvements label Jun 5, 2023
@getreu
Copy link
Contributor

getreu commented Jun 11, 2023

I run into the same problem with the same use case. In general, I suppose the reason for the exit error code is, that when the language server has no time to shut down properly, the edited files can be left in an inconsistent state, e.g. when you rename a variable with LSP. In case of ltex-ls the problem is not the shut-down time, but it is the long start-up time. Nevertheless, while starting ltex-ls, it should be OK to kill the ltex-ls process and to exit hx without an exit error code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants