Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing build (aarch64-macos) for 22.03 release #6495

Closed
rossjones opened this issue Mar 31, 2023 · 5 comments · Fixed by #6504
Closed

Missing build (aarch64-macos) for 22.03 release #6495

rossjones opened this issue Mar 31, 2023 · 5 comments · Fixed by #6504
Assignees
Labels
A-packaging Area: Packaging and bundling

Comments

@rossjones
Copy link

rossjones commented Mar 31, 2023

The new 23.03 release (https://github.com/helix-editor/helix/releases/tag/23.03) doesn't have an ARM version for OSX, whereas one exists for the previous releases.

Was expecting to find the release at https://github.com/helix-editor/helix/releases/download/23.03/helix-23.03-aarch64-macos.tar.xz

Edit: Looks like build issues mean it was disabled earlier
e59cb19

@the-mikedavis the-mikedavis added the A-packaging Area: Packaging and bundling label Mar 31, 2023
@the-mikedavis
Copy link
Member

The aarch64 darwin build ran into a cross-compilation problem https://github.com/helix-editor/helix/actions/runs/4572207374/jobs/8071312127

Once that's fixed we should be able to push a darwin aarch64 artifact to the existing 23.03 release.

In the meantime you can building from source but please follow the full from-source build instructions. Installing using only cargo and the git URL will not properly install Helix and you will not have tree-sitter features or a tutor file. https://docs.helix-editor.com/install.html#building-from-source

@the-mikedavis
Copy link
Member

It looks like this was caused by switching from the old rust-toolchain action to the new one (https://github.com/dtolnay/rust-toolchain). The old one would call rustup target add if the target option was passed (see here) while the new one only calls rustup toolchain install (see here).

We could call rustup target add ourselves (982574c, https://github.com/helix-editor/helix/actions/runs/4575803555/jobs/8079298943) but I think it's better to fix this upstream since the behavior is a little surprising. Once that build finishes I'll upload the artifact to the 23.03 release and then send a PR upstream

@rossjones
Copy link
Author

Thanks for the update. I've removed my bad advice for installing, and will reinstall from the instructions.

@the-mikedavis
Copy link
Member

I just uploaded the aarch64-macos artifact to https://github.com/helix-editor/helix/releases/tag/23.03

#6504 should fix this in the long-run

@rossjones
Copy link
Author

Thanks for the super-speedy turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-packaging Area: Packaging and bundling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants