Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left-align diagnostic text #6223

Closed
helmesjo opened this issue Mar 7, 2023 · 4 comments
Closed

Left-align diagnostic text #6223

helmesjo opened this issue Mar 7, 2023 · 4 comments
Labels
C-enhancement Category: Improvements

Comments

@helmesjo
Copy link

helmesjo commented Mar 7, 2023

When looking at diagnostics from the language server the text-box is displayed in the top right-hand side, but it's also right-aligned making it awkward to read:

image

I'm not aware of any previous discussions regarding this (or if it's used for other things as well), but at least in situations as above it should just be left-aligned to be readable with anything but trivial diagnostics.

@helmesjo helmesjo added the C-enhancement Category: Improvements label Mar 7, 2023
@kirawi
Copy link
Member

kirawi commented Mar 7, 2023

There is #6059

@helmesjo
Copy link
Author

helmesjo commented Mar 7, 2023

Ah, thanks! Though since PRs tend to lack useful descriptions, is that PR replacing the message output or just extending with some opt-in feature (eg. additional tools would be required besides a language-server or I'd have to enable it through in the config)? If not, then great, I can close this. Else I still think fixing up the message output would be useful. Not sure when right-aligned is ever useful for, well, text in general.

@kirawi
Copy link
Member

kirawi commented Mar 7, 2023

It'll be replacing it I believe, and it doesn't requrie anything extra.

@helmesjo
Copy link
Author

helmesjo commented Mar 26, 2023

#6417 seems to be the one to wait for.

@helix-editor helix-editor locked and limited conversation to collaborators Apr 7, 2024
@pascalkuthe pascalkuthe converted this issue into discussion #10209 Apr 7, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

2 participants