Line is soft-wrapped even if within max-line-length limit

[jlebon]

Summary

With soft-wrap.enable = true, when editing files with a max-line-length, lines may be soft-wrapped even if it would've fit within the max-line-length limit. This is most easily seen when writing git commits:

The singular A (preceded by a space) would've fit within column 72. :reflow calculates it correctly and does not break line, so the soft-wrap persists.

Platform

Linux

Terminal Emulator

tmux inside GNOME Terminal

Helix Version

22.12-218-gf7bd7b5e

[pascalkuthe]

The reason for this is that newlines are always a selectable character in helix that takesup horizontal space. The line needs to be wrapped here because otherwise the newline character exceeds the 72 column width limit. I could change the max-line-length option to be interpreted as max-line-length + 1 for softwrap purposes to remedy that but that would not work correctly on the last line (which doesn't have a newline character).

[jlebon]

The reason for this is that newlines are always a selectable character in helix that takesup horizontal space. The line needs to be wrapped here because otherwise the newline character exceeds the 72 column width limit.

Though note :reflow does not count the newline character towards the max-line-length limit. I expected the softwrap logic to also match this. If they don't agree, the rendering will not converge. To put this another way, I would expect a freshly :reflowed paragraph to not display any softwrapped lines.

[pascalkuthe]

Yeah I suppose that is the lesser of two evils here. submitted #5813 with a fix

[gabydd]

I believe this was fixed by #5893