Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing eof newline #4933

Closed
baffling-knee opened this issue Nov 29, 2022 · 2 comments
Closed

missing eof newline #4933

baffling-knee opened this issue Nov 29, 2022 · 2 comments
Labels
C-bug Category: This is a bug R-duplicate Duplicated issue: please refer to the linked issue

Comments

@baffling-knee
Copy link

Summary

unlike vim and neovim, helix doesnt add a eof newline at the end of file.
causes issues when submit files to github for ex and warning is show.
possible to do automatic like vim or with config option please?

Reproduction Steps

I tried this:

  1. hx edit new file
  2. add content and save+quit
  3. look for eof newline - is missing

I expected this to happen:

eof newline add automatic like vim

Instead, this happened:

no eof newline. have to open in vim and save to add it

Helix log

~/.cache/helix/helix.log
please provide a copy of `~/.cache/helix/helix.log` here if possible, you may need to redact some of the lines

Platform

all

Terminal Emulator

all

Helix Version

22.08.1

@baffling-knee baffling-knee added the C-bug Category: This is a bug label Nov 29, 2022
@gabydd
Copy link
Member

gabydd commented Nov 29, 2022

Lol turns out my GitHub searching was not good enough and there is a duplicate for this my bad: #4274

@the-mikedavis
Copy link
Member

Duplicate of #4274

@the-mikedavis the-mikedavis marked this as a duplicate of #4274 Nov 29, 2022
@the-mikedavis the-mikedavis closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2022
@the-mikedavis the-mikedavis added the R-duplicate Duplicated issue: please refer to the linked issue label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug R-duplicate Duplicated issue: please refer to the linked issue
Projects
None yet
Development

No branches or pull requests

3 participants