Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang autocompletion does not replace the partial word #4131

Closed
sbromberger opened this issue Oct 6, 2022 · 4 comments
Closed

golang autocompletion does not replace the partial word #4131

sbromberger opened this issue Oct 6, 2022 · 4 comments
Labels
A-language-server Area: Language server client C-bug Category: This is a bug upstream

Comments

@sbromberger
Copy link
Contributor

Summary

Possibly related:

When completing a word with gopls, after selecting the completion term, the already-typed text does not get replaced. Therefore, completing str with string results in strstring.

go 1.19.2
gopls 0.9.5

Reproduction Steps

https://asciinema.org/a/nsZSjqqLLgm17ZYqstbpEtVJA

Helix log

~/.cache/helix/helix.log
2022-10-06T17:10:34.453 helix_lsp::transport [ERROR] <- ServerError(0): 4:21: expected type, found newline
2022-10-06T17:10:34.454 helix_view::document [WARN] LSP formatting failed: protocol error: ServerError(0): 4:21: expected type, found newline                                                         
2022-10-06T17:10:34.717 helix_lsp::transport [ERROR] err: <- StreamClosed

Platform

linux

Terminal Emulator

tmux

Helix Version

helix 22.08.1 (7e74e93)

@sbromberger sbromberger added the C-bug Category: This is a bug label Oct 6, 2022
@kirawi kirawi added the A-language-server Area: Language server client label Oct 7, 2022
@xbol0
Copy link

xbol0 commented Oct 10, 2022

Right, when complete func TestFoo will become func TestFoo(t *testing.T)TestFoo.

@the-mikedavis the-mikedavis linked a pull request Oct 10, 2022 that will close this issue
@sbromberger
Copy link
Contributor Author

@the-mikedavis - #1819 doesn't fix this problem, at least in my testing. (I added a comment there.)

@archseer
Copy link
Member

Seems to be an upstream issue #5487 (comment)

@archseer
Copy link
Member

archseer commented Mar 9, 2023

Should be fixed upstream now golang/go#57480

@archseer archseer closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-server Area: Language server client C-bug Category: This is a bug upstream
Projects
None yet
Development

No branches or pull requests

5 participants