-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S-return in file picker should open file in the background and keep the picker open with the same search query #3924
Comments
Take a look at |
I'd also love to see this feature added but just wanted to throw in some suggestions for how it could work:
The would enable scenarios such as searching across a codebase and editing multiple files matching a search criteria without having to repeat the search again. @Itay123TheKing I hope my idea aligns with what you were thinking but please let me know what you think. Edit: Updated what I think keybindings should be |
@gavynriebau I was thinking of some keybind that would simply load the file in a new buffer without closing the picker, that wy you could use that keybind on every file you want to open until the last one, which you could open with normal enter and it would close the picker and focus the new buffer. This approach also aligns really well with the existing code, adding |
@Itay123TheKing thanks, good call on The user flow would then be arrow up/down and press This would have the small advantage they could mark/unmark files for editing before opening them all in case they change their mind |
The checklist idea is interesting but it would take quite some work to implement. In scenarios where I want this feature, I have a file I'm interested in selected already and the file I'm really looking for still needs more typing to find. The "open in the background" idea works well for that but with checklists how do you see files that you've checked that no longer match the filter? Do they show up anyway? |
Ah, I see what you mean and in that case opening in the background definitely makes sense. The ability to open in the background and the "checklist" type behaviour could be separate features but in this issue perhaps we should just focus on the original idea of opening files in the background. I think the checklist style selection approach could work well with the open in background feature but could be added later |
I don’t recommend using |
Hey sorry for not working on this, I think I should be able to PR later today. But should we go A-ret or tab or? |
Also maybe right click should also do this? |
I hope I did this right. I decided not to implement right click because as I discovered not even left click is implemented |
A lot of the time I want to open multiple files at once from the file picker and I think this small qol feature could make it easier to do so.
I would like to help write a PR to close this issue myself. Could anyone direct me as to where I should be looking to see how to make this work?
The text was updated successfully, but these errors were encountered: