Indent guides displaying without theming on blank lines

[Omnikar]

Summary

On blank lines, indentation guides other than the leftmost will display as white instead of their correct theme colour.

I tested with different themes, and oddly, it seems that it happens on most, but not all of the themes that come with Helix. Themes that seem to work fine:

• The default theme
• base16_transparent
• All the catppuccin_* themes
• flatwhite
• meliora
• noctis and noctis_bordo
• nord_light
• onedark and onelight
• pop-dark (side note: shouldn't this theme name use an underscore?)
• solarized_dark and solarized_light

In the case of the base16_default and dracula_at_night themes, the default indent guide colour seems to be white, so I don't know if this bug occurs, but for all the rest of the not listed themes, this bug does occur.

Reproduction Steps

1. Use a theme not listed above.
2. Write code with at least 2 levels of indentation.
3. Insert a blank line somewhere at the second indentation level.
4. Ensure the blank line contains no whitespace characters.

Helix log

2022-08-02T02:48:59.327 helix_view::theme [WARN] Theme: malformed hexcode: grey
2022-08-02T02:48:59.550 helix_view::theme [WARN] Theme: malformed hexcode: grey
2022-08-02T02:48:59.797 helix_view::theme [WARN] Theme: malformed hexcode: grey
2022-08-02T02:49:01.434 helix_view::theme [WARN] Theme: malformed hexcode: greay
2022-08-02T02:49:01.435 helix_view::theme [WARN] Theme: malformed hexcode: purple
2022-08-02T02:49:01.435 helix_view::theme [WARN] Theme: malformed hexcode: light-grey
2022-08-02T02:53:29.576 helix_view::theme [WARN] Theme: malformed hexcode: grey
2022-08-02T02:53:29.987 helix_view::theme [WARN] Theme: malformed hexcode: grey
2022-08-02T02:53:30.530 helix_view::theme [WARN] Theme: malformed hexcode: grey
2022-08-02T02:53:36.688 helix_view::theme [WARN] Theme: malformed hexcode: purple
2022-08-02T02:53:36.688 helix_view::theme [WARN] Theme: malformed hexcode: light-grey
2022-08-02T02:53:36.689 helix_view::theme [WARN] Theme: malformed hexcode: greay
2022-08-02T02:53:42.710 helix_view::theme [WARN] Theme: malformed hexcode: light-grey
2022-08-02T02:53:42.711 helix_view::theme [WARN] Theme: malformed hexcode: purple
2022-08-02T02:53:42.711 helix_view::theme [WARN] Theme: malformed hexcode: greay
2022-08-02T02:54:03.626 helix_view::theme [WARN] Theme: malformed hexcode: grey
2022-08-02T02:54:03.758 helix_view::theme [WARN] Theme: malformed hexcode: grey
2022-08-02T02:54:04.429 helix_view::theme [WARN] Theme: malformed hexcode: grey
2022-08-02T02:54:06.270 helix_view::theme [WARN] Theme: malformed hexcode: grey
2022-08-02T02:54:06.593 helix_view::theme [WARN] Theme: malformed hexcode: grey
2022-08-02T02:54:07.036 helix_view::theme [WARN] Theme: malformed hexcode: grey
2022-08-02T02:54:10.017 helix_view::theme [WARN] Theme: malformed hexcode: greay
2022-08-02T02:54:10.018 helix_view::theme [WARN] Theme: malformed hexcode: purple
2022-08-02T02:54:10.018 helix_view::theme [WARN] Theme: malformed hexcode: light-grey
2022-08-02T02:54:12.305 helix_view::theme [WARN] Theme: malformed hexcode: light-grey
2022-08-02T02:54:12.305 helix_view::theme [WARN] Theme: malformed hexcode: greay
2022-08-02T02:54:12.305 helix_view::theme [WARN] Theme: malformed hexcode: purple
2022-08-02T02:54:34.498 helix_view::theme [WARN] Theme: malformed hexcode: greay
2022-08-02T02:54:34.499 helix_view::theme [WARN] Theme: malformed hexcode: purple
2022-08-02T02:54:34.499 helix_view::theme [WARN] Theme: malformed hexcode: light-grey
2022-08-02T02:54:35.348 helix_view::theme [WARN] Theme: malformed hexcode: purple
2022-08-02T02:54:35.348 helix_view::theme [WARN] Theme: malformed hexcode: greay
2022-08-02T02:54:35.348 helix_view::theme [WARN] Theme: malformed hexcode: light-grey
2022-08-02T02:54:36.720 helix_view::theme [WARN] Theme: malformed hexcode: purple
2022-08-02T02:54:36.720 helix_view::theme [WARN] Theme: malformed hexcode: greay
2022-08-02T02:54:36.720 helix_view::theme [WARN] Theme: malformed hexcode: light-grey
2022-08-02T02:54:41.052 helix_view::theme [WARN] Theme: malformed hexcode: grey
2022-08-02T02:54:41.263 helix_view::theme [WARN] Theme: malformed hexcode: grey
2022-08-02T02:54:41.471 helix_view::theme [WARN] Theme: malformed hexcode: grey
2022-08-02T02:54:43.641 helix_view::theme [WARN] Theme: malformed hexcode: light-grey
2022-08-02T02:54:43.643 helix_view::theme [WARN] Theme: malformed hexcode: greay
2022-08-02T02:54:43.643 helix_view::theme [WARN] Theme: malformed hexcode: purple
2022-08-02T02:55:00.452 helix_view::theme [WARN] Theme: malformed hexcode: grey
2022-08-02T02:59:29.048 helix_view::theme [WARN] Theme: malformed hexcode: grey

This has led me to notice that the base16_transparent theme has a typo of gray as greay.

Platform

MacOS

Terminal Emulator

iTerm2 v3.4.16

Helix Version

Helix 22.05 (aa4394ce)

[the-mikedavis]

It may be some interaction between the ui.virtual.whitespace and lack of a ui.virtual.indent-guide or ui.virtual scopes in a theme? Themes that have this behavior like gruvbox or nord have only ui.virtual.whitespace highlights

[the-mikedavis]

For the malformed hexcodes, I think gray is valid but not grey and also I don't think purple is a valid base16 color, instead magenta. greay is definitely not right 😄

[Omnikar]

It may be some interaction between the ui.virtual.whitespace and lack of a ui.virtual.indent-guide or ui.virtual scopes in a theme? Themes that have this behavior like gruvbox or nord have only ui.virtual.whitespace highlights

This seems to accurately account for all the working themes except noctis_bordo and nord_light; I notice though that in the case of these two themes, neither one of them includes a definition for whitespace or indent-guide.