Close hover documentation when cursor leaves the symbol

[teenjuna]

Currently when we press K to open documentation for the symbol under the cursor and then move the cursor somewhere else, the documentation doesn't disappear and follows the cursor:

Screen.Recording.2021-06-20.at.17.52.45.mov

I find this somewhat counter-intuitive. I expect it to disappear as soon as the cursor leaves the symbol. Is it intentional or should we try to fix this?

Environment

• Platform: macOS
• Helix version: v0.2.1-49-g2cbec2b

[archseer]

Would like to fix this but I might want to add a proper hook system first so these things can be properly abstracted.

[archseer]

Quick workaround would probably be Event::Ignored also taking a callback so we could catch the key in handle_event, ignore it, but still trigger a close.

[jens1205]

With hx v0.4.1 on Mac, the hover is not following the cursor any more - but it does not close either. So I can open a lot of hover documentation for different items the same time.

But nothing closes if I move the cursor away, what is what I expect. So how is the documentation closed?

[archseer]

Esc

[jens1205]

Indeed, this works. I haven't noticed, because I first tried to close / toggle the hover documentation again with K. But this apparently leads to another instance of the hover window to be placed "on top" of the other. And after pressing twice K, you have to press twice Esc.

Even more strange is the behaviour if you enter into insert mode while having one or more hover windows open. Now Esc does not switch to normal mode, but instead you first have to close all hover windows before you can leave insert mode.

I don't think this beaviour is wanted. Either the hover window should be closed upon cursor movement. Or the window should be toggable via K.

[kirawi]

Duplicate of #14

[kirawi]

Nevermind, it's not a duplicate.