Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File picker default highlight #3014

Closed
mangas opened this issue Jul 8, 2022 · 4 comments
Closed

File picker default highlight #3014

mangas opened this issue Jul 8, 2022 · 4 comments
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements

Comments

@mangas
Copy link
Contributor

mangas commented Jul 8, 2022

Describe your feature request

I think it could be very handy to highlight the current file by default on the picker so that files from the same folder are close for selection.

@mangas mangas added the C-enhancement Category: Improvements label Jul 8, 2022
@kirawi kirawi added the A-theme Area: Theme and appearence related label Jul 9, 2022
@the-mikedavis
Copy link
Member

To be clear, highlighting in this context is selecting the current file first and not syntax highlighting, correct?

So the behavior here would be that when the file picker's prompt is empty, the sort order should push the current file and files in its directory to the top?

@mangas
Copy link
Contributor Author

mangas commented Jul 9, 2022

That's correct, sorting the current file and directory up when no there is no filter

@pascalkuthe
Copy link
Member

You mentinoed that #4666 was an alternative take on this issue. Does that mean that you view this feature-request as done now and this issue can be closed?

@mangas
Copy link
Contributor Author

mangas commented Feb 2, 2023

I would rather the approach of selecting the current file by default since it's more generic and one less keybinding. I seem to remember that @the-mikedavis was not a fan of this proposal so I leave this up to you guys. Personally I would rather work on and merge https://github.com/mangas/helix/tree/select-current-file-picker. If the maintainers do not agree then I guess we could close it

@helix-editor helix-editor locked and limited conversation to collaborators Apr 13, 2024
@pascalkuthe pascalkuthe converted this issue into discussion #10396 Apr 13, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

4 participants