Clicking past the end of a line triggers yank

[CptPotato]

Summary

When clicking past the end of a line, helix yanks the text as if I clicked and dragged.

This also seems to happen when clicking other positions in the terminal, such as the gutter (although in that case the cursor position remains unchanged). I suspect that this happens whenever a click doesn't land on a character from the document.

Reproduction Steps

• open helix
• click anywhere on the first line or the status line
  • helix reports: yanked main selection to system clipboard

Helix log

Nothing helpful is logged

Platform

Windows

Terminal Emulator

wezterm, cmd, powershell

Helix Version

helix 22.05 (built from master 4a27e2d9)

[the-mikedavis]

This may be windows-specific. I can't reproduce on wezterm on linux

[CptPotato]

I'll try it on my linux machine later to confim.

[CptPotato]

Yup, seems to be Windows specific. I can't reproduce on Linux either (foot terminal). (incorrect, see below)

[CptPotato]

The behavior is a bit hard to describe; here's a quick visualization of what happens when clicking different areas:

• #49a720 green: works as expected (moves the cursor but doesn't yank)
• #a81d21 red: moves the cursor but also yanks
• #a88e20 yellow: moves the cursor but doesn't yank (probably because it's past the end of the document)
• #2084a8 blue: doesn't change the cursor position; yanks if the cursor is currently on a new line character (i.e. red area)

---

Edit: actually.. it looks like this is not a windows issue, but an issue with crlf line endings 😕
I guess crlf is interpreted as a two char selection, resulting in a yank.

[the-mikedavis]

I haven't tested it out yet but I bet it's this block:

helix/helix-term/src/ui/editor.rs

Lines 1086 to 1104 in e053277

	MouseEvent {
	kind: MouseEventKind::Up(MouseButton::Left),
	..
	} => {
	if !config.middle_click_paste {
	return EventResult::Ignored(None);
	}
	let (view, doc) = current!(cxt.editor);
	let range = doc.selection(view.id).primary();
	if range.to() - range.from() <= 1 {
	return EventResult::Ignored(None);
	}
	commands::MappableCommand::yank_main_selection_to_primary_clipboard.execute(cxt);
	EventResult::Consumed(None)
	}