Crash on LSP diagnostic

[dead10ck]

Summary

I experienced a crash of helix with this message:

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /home/dead10ck/src/helix/helix-term/src/application.rs:459:81
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This was on d2b1add and the problematic issue is here:

helix/helix-term/src/application.rs

Lines 441 to 459 in d2b1add

	Notification::PublishDiagnostics(params) => {
	let path = params.uri.to_file_path().unwrap();
	let doc = self.editor.document_by_path_mut(&path);
	if let Some(doc) = doc {
	let lang_conf = doc.language_config();
	let text = doc.text();
	let diagnostics = params
	.diagnostics
	.into_iter()
	.filter_map(|diagnostic| {
	use helix_core::{
	diagnostic::{Range, Severity::*},
	Diagnostic,
	};
	use lsp::DiagnosticSeverity;
	let language_server = doc.language_server().unwrap();

It appears that it was trying to handle a diagnostic message before the LSP was fully initialized, and this code seems to assume that if we are handling this message, the LSP must be fully initialized.

Helix Version

helix d2b1add

[lebakasable]

The problem is already fixed I think update your Helix

[dead10ck]

@frexsdev oh, I don't see any change? It still looks the same to me:

helix/helix-term/src/application.rs

Line 465 in 82da9bd

let language_server = doc.language_server().unwrap();

Was it fixed somewhere else in the code?

[pascalkuthe]

This was fixed by #7467