Feature request: Popup for LSP diagnostics

[Domerpig]

The LSP diagnostics in the upper right corner can sometimes be way out of my view and I have to glance back and forth between my code and the diagnostic. An option to have a popup that shows the diagnostic at the same place of the code would be nice. Or maybe showing it at the end of the line. Just somewhere closer.

[kirawi]

Related to #411

[kaleidawave]

Have found the code for rendering diagnostics, which is called by render_view (found above in the file)

helix/helix-term/src/ui/editor.rs

Lines 600 to 652 in 370a16d

	pub fn render_diagnostics(
	&self,
	doc: &Document,
	view: &View,
	viewport: Rect,
	surface: &mut Surface,
	theme: &Theme,
	) {
	use helix_core::diagnostic::Severity;
	use tui::{
	layout::Alignment,
	text::Text,
	widgets::{Paragraph, Widget, Wrap},
	};
	let cursor = doc
	.selection(view.id)
	.primary()
	.cursor(doc.text().slice(..));
	let diagnostics = doc.diagnostics().iter().filter(|diagnostic| {
	diagnostic.range.start <= cursor && diagnostic.range.end >= cursor
	});
	let warning = theme.get("warning");
	let error = theme.get("error");
	let info = theme.get("info");
	let hint = theme.get("hint");
	let mut lines = Vec::new();
	for diagnostic in diagnostics {
	let text = Text::styled(
	&diagnostic.message,
	match diagnostic.severity {
	Some(Severity::Error) => error,
	Some(Severity::Warning) | None => warning,
	Some(Severity::Info) => info,
	Some(Severity::Hint) => hint,
	},
	);
	lines.extend(text.lines);
	}
	let paragraph = Paragraph::new(lines)
	.alignment(Alignment::Right)
	.wrap(Wrap { trim: true });
	let width = 100.min(viewport.width);
	let height = 15.min(viewport.height);
	paragraph.render(
	Rect::new(viewport.right() - width, viewport.y + 1, width, height),
	surface,
	);
	}

Wondering how hard it would be to add a option to render it either under the cursor while it is highlighted or something?

[jakenvac]

I think this falls under the same issue, but I have a slightly different grievance.

Very often imports in various languages are at the top of the file, and very often I make typos when importing stuff.

The LSP complains and then gets in the way of me fixing the issue.

please ignore that I'm using archaic nodeJS, some clients like it old school 😭

[poliorcetics]

On master there is now space+g/G for file/workspace diangostic which makes the user jump to the exact position of the diagnostic, does it at least partially fix the issue ?

[pascalkuthe]

I think is is a duplicate of #1953 so I am closing this issue in favor of that. If you don't think that is right and that these are two separate issues feel free to reopen.

[AddictArts]

For anyone else trying to find it, now space+d, the g is the debug experimental.