Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/document special key in theme files #2380

Open
ChrHorn opened this issue May 3, 2022 · 3 comments
Open

Rename/document special key in theme files #2380

ChrHorn opened this issue May 3, 2022 · 3 comments
Labels
A-documentation Area: Documentation improvements A-theme Area: Theme and appearence related C-enhancement Category: Improvements

Comments

@ChrHorn
Copy link
Contributor

ChrHorn commented May 3, 2022

There is a key special in theme files that is used for the fuzzy highlighting in the file/command picker
image

this key is

  • undocumented
  • has a misleading name
  • might also be used as a treesitter grammar scope (not sure)
@archseer
Copy link
Member

archseer commented May 3, 2022

It's special because it's used for special syntax symbols like ? operator in rust. The fuzzy finder PR that implemented highlighting simply reused it because it had the right color.

@ChrHorn
Copy link
Contributor Author

ChrHorn commented May 3, 2022

Makes sense #1635

In my opinion this should be a seperate entry, maybe default to bold?
Better to keep syntax highlighting and UI seperate.

@kirawi kirawi added A-documentation Area: Documentation improvements C-enhancement Category: Improvements labels May 3, 2022
@the-mikedavis
Copy link
Member

I've been meaning to make this same issue 😀

I wouldn't mind keeping around special for things like Rust's ? but there are other cases where it makes less sense that I've come across:

  • Elixir sigils
  • markdown bullet points / lists
  • matching for fuzzy highlighting

Some of these can be themed with existing scopes but others need some new scopes and it'd be nice to update the existing themes to add them were possible.

@the-mikedavis the-mikedavis added the A-theme Area: Theme and appearence related label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documentation Area: Documentation improvements A-theme Area: Theme and appearence related C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

4 participants