Auto import doesn't work

[sohnryang]

Summary

I tried out the auto-import feature that got merged recently, but it is not working.

Reproduction Steps

I tried this:

0. Create a new Rust project using cargo new test_project, and cd to the project root.
1. Run the editor using hx src/main.rs.
2. Make a new line after the line containing println!, and type Dur.
3. LSP suggests Duration. Select it by pressing control-n.

I expected this to happen:
By selecting the suggestion, use std::time::Duration should be added to the source code.

Instead, this happened:
The editor completes to Duration, but does not add use statement to the code.

Helix log

The log is too long, so I'll attach it separately.
helix.log

Platform

Linux (kernel version: 5.17.2-arch3-1)
rust-analyzer 2022-04-11

Terminal Emulator

wezterm 20220408-101518-b908e2dd

Helix Version

22.03-95-gc45fb08a

[archseer]

@andreytkachenko I also can't get this working, the completion appears but the import isn't getting added. I assume additionalTextEdits isn't resolved correctly

[andreytkachenko]

@archseer The only case I can reproduce the bug - if there are some changes happened between complete and resolve requests and server responds with content changed error (I guess we need handle that error somehow). But I didn't noticed any resolve requests in attached logs. It looks like additionalTextEdits contains something, but logs don't shows that additionalTextEdits in after complete contains something. Sorry I need more data to reproduce that. I am using RA version 2022-03-28, helix 22.05-dev (855e438), both debug and release, wezterm, alacritty, gnome-terminal. But unable to reproduce it. I did pure clone and pure cargo new for demo project, but it works.

[theli-ua]

I can reproduce this if I start typing Dur and make selection before ra completes indexing/etc. With "content modified" error from server

[sohnryang]

I realized that I had to press enter in order to get auto-import... 😅
Works fine for me now. Should I close this ticket?

[andreytkachenko]

I can confirm that problem is not solved. I will fix it. Leave it open please for reference.

[pascalkuthe]

I can not reproduce this anymore. It's hard to retroactively pinpoint but I guess this was likely fixed by #6173 or #6594 (likely the latter)