-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log file shouldn't be created or written to by default #1135
Comments
Well, we went full circle on this. There was a bug that made us log continually every second when the LSP crashed. Which lead us to truncate the file each time. But then trying to open the logfile (or opening multiple helix instances) would wipe the file before you could read it. |
Which is why IMO it should write to stderr by default, or the specified file, and only when run with |
Logging only critical errors is helpful in the case of a crash though. Especially when we get bug reports from stripped builds that don't have a proper backtrace. |
In that case, I think a good first step would be to write to stderr by default (and continue logging even without |
Maybe we could warn the user in Helix if their log is huge. Or maybe that's just lazy, idk. |
I looked into logging to However, as part of reviewing this ticket, I've opened a fix for the open-log command |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Describe your feature request
The log file should be truncated, and should only be written to when using one of the verbosity flags. I can see, some day in the (distant?) future, where some user writes a post about how their helix log file was taking up gigabytes of disk space because it's append-only and never cleaned up.
The verbosity flag should take a filename argument that will then be created (if it doesn't exist) or truncated (if it does) and begin writing its logging information to it.
The text was updated successfully, but these errors were encountered: