Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select items from history in Pickers (global_search) #11210

Open
the-mikedavis opened this issue Jul 17, 2024 · 3 comments
Open

Select items from history in Pickers (global_search) #11210

the-mikedavis opened this issue Jul 17, 2024 · 3 comments
Labels
A-command Area: Commands C-enhancement Category: Improvements

Comments

@the-mikedavis
Copy link
Member

the-mikedavis commented Jul 17, 2024

Originally discussed in #11205

The refactored global_search picker from #9647 lets you accept the most recent item from history if there is something already in the history register (/ by default) and you hit Enter. It's useful to select other items from history too. Most minimally we need keybinds that go forward and backwards in the history, like A-n/A-p and/or A-down/A-up for example. In the long run it could also be nice to find a UI for the completions themselves, maybe something layering over the picker or a new pane that shows up when there are completions.

@the-mikedavis the-mikedavis added C-enhancement Category: Improvements A-command Area: Commands labels Jul 17, 2024
@xJonathanLEI
Copy link
Contributor

Just to quickly quote @pascalkuthe on #11205:

The old.prompt doesn't shown a history either.

Actually it does:

image

I agree it can be tricky to get the UI done right in the picker context though.

@woojiq
Copy link
Contributor

woojiq commented Dec 6, 2024

Is there any workaround for this (better than mine)?

I have to open the local search prompt and copy the desired entry with mouse. Then paste it into global search picker.

@xJonathanLEI
Copy link
Contributor

@woojiq You don't actually have to do the mouse copying. You can just do / to initiate a local search, then navigate to the item desired (through up and down arrow keys), and hit <enter>. Now do <space> / and it shows up in the picker as placeholder, and you'd just have to press <enter> to activate it.

Is it inferior to having a native history navigation UX within the picker? Yes. But it's much nicer than the alternative workaround you've described since you don't have to use the mouse (or tmux copy mode, for that matter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-command Area: Commands C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

3 participants