Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

m should work with the nearest surround pair even if the cursor is not exactly on a surround character #1072

Closed
archseer opened this issue Nov 11, 2021 · 3 comments · Fixed by #1946
Closed

m should work with the nearest surround pair even if the cursor is not exactly on a surround character #1072

archseer opened this issue Nov 11, 2021 · 3 comments · Fixed by #1946
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@archseer
Copy link
Member

Leftover from #961
@archseer archseer added the C-enhancement Category: Improvements label Nov 11, 2021
@kirawi kirawi added A-core Area: Helix core improvements A-helix-term Area: Helix term improvements E-easy Call for participation: Experience needed to fix: Easy / not much and removed A-core Area: Helix core improvements labels Nov 11, 2021
@s1ck s1ck mentioned this issue Nov 17, 2021
Merged
@archseer archseer removed the E-easy Call for participation: Experience needed to fix: Easy / not much label Nov 24, 2021
@the-mikedavis the-mikedavis mentioned this issue Apr 17, 2022
Open
@icholy
Copy link

icholy commented Apr 17, 2022

An alternative would be to leave m as-is and add a ]* where * is any character acting as a pair. So ]" would select the next string.

@the-mikedavis
Copy link
Member

I would prefer it work at least like m because m can distinguish between around (ma) and inside (mi). Although having control over whether we seek the next ] or previous [ could be useful. I think we should choose one (probably "next") as a default behavior for m when not surrounded though for simplicity of use, even if it's a duplicate keybinding.

@sudormrfbin sudormrfbin linked a pull request Apr 17, 2022 that will close this issue
Add m textobject to select closest surround pair #1946
Merged
@icholy
Copy link

icholy commented Apr 17, 2022

What about allowing [ or ] as a prefix for any m commands?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add m textobject to select closest surround pair sudormrfbin/helix
4 participants
@icholy @archseer @the-mikedavis @kirawi