Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ada_language_server listed twice #10316

Closed
cloudlena opened this issue Apr 9, 2024 · 5 comments · Fixed by #10563
Closed

ada_language_server listed twice #10316

cloudlena opened this issue Apr 9, 2024 · 5 comments · Fixed by #10563
Labels
C-bug Category: This is a bug

Comments

@cloudlena
Copy link

cloudlena commented Apr 9, 2024

Summary

When running hx --health, ada_language_server is listed twice:

The same goes for the documentation

| ada ||| | `ada_language_server`, `ada_language_server` |
.

To me, this is quite confusing. Is it correct?

Reproduction Steps

  1. Run hx --health ada

Helix log

No response

Platform

Linux

Terminal Emulator

alacritty

Installation Method

nixpkgs

Helix Version

helix 24.03

@cloudlena cloudlena added the C-bug Category: This is a bug label Apr 9, 2024
@archseer
Copy link
Member

archseer commented Apr 9, 2024

Please submit a PR

@cloudlena
Copy link
Author

Thanks, @archseer. I'm happy to provide a PR.
However, the issue seems to be that the documentation is generated from https://github.com/helix-editor/helix/blob/master/languages.toml. It only takes the command property of the language servers which, in case of ada is the same for both options because they only differ in the args. I'm not sure how to sustainably propagate that differentiation.

Ideally, it would be done in an automated way but ignoring the args for all other language servers to avoid cluttering the docs. What do you think? Do you have any guidance on how to proceed?

@the-mikedavis
Copy link
Member

Deduplicating the command names seems like the right choice to me here. Or we could switch that column from the name of the binary to the name of the language server. That column predates #2507 which refactored language servers so that they have names in the config

@timothyhutz
Copy link
Contributor

As a new Rust Dev, can I take this fix? I'll send you a PR from my fork.

@timothyhutz
Copy link
Contributor

Fixed and tested #10563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants