Odin : Formatting appears to be broken.

[sortofsleepy]

Summary

👋

Not sure if this is an OLS issue or a Helix issue but trying out Helix at the moment and formatting seems to be broken for some reason.

• No format on save
• :fmt , etc doesn't work
• Going through the command list doesn't work.
• no additional config changes have been made other than theme and cursor style.

Running helix --health odin seems to suggest everything is ok. It is able to find where I put OLS and in general, OLS does appear to work. It's just the formatting that's broken. odinfmt is on my PATH and I have confirmed it can run on it's own. Odin / OLS stuff is all up-to-date

Reproduction Steps

1. Make a new Odin file
2. Start typing code while purposely writing in a way that should trigger the formatter(for instance, not adding a tab/space)
3. Try to save or run the formatter
4. Notice how no formatting is applied.

Helix log

There are a repeated groups of messages like the following

2025-01-16T05:12:55.946 helix_lsp::transport [ERROR] ols err: <- StreamClosed
2025-01-16T05:13:04.834 helix_lsp::transport [ERROR] ols err: <- StreamClosed
2025-01-16T05:13:26.160 helix_lsp::transport [ERROR] err: <- Other(failed to send a message to server)

Platform

Linux

Terminal Emulator

Ghostty, WezTerm

Installation Method

Manual from github.

Helix Version

helix 25.01

[the-mikedavis]

What does the log say when running in verbose mode? hx -v --log log.txt and attach log.txt

[sortofsleepy]

Ah! apologies, i always seem to miss it when the discussion tab is enabled.

Log is attached (with some minor edits to mask my directory structure)

log.txt

For reference this is the test code

package main

main :: proc(){
a := 32 
}

[the-mikedavis]

I haven't been able to reproduce this locally. I'm using NixOS and the odin and ols packages which also include odinfmt. I added some extra logging for external formatting commands - previously we didn't log anything when a formatter command failed. You can try building from source and re-running this example and posting the new log, or there should be a patch release 25.01.1 soon that will include the extra logging

[sortofsleepy]

Looking at my initial post I somehow just realized I mis-spoke; I'm actually installing manually vs using pacman(on Arch); probably not it but I wonder if there's a difference in versions perhaps.

Well anyways, if there's gonna be a new release soon, I'll just put this issue aside for the time being and wait and see what happens. I'll open a new discussion with the extra log info then.

Thanks for the quick response!

[sortofsleepy]

For anyone that happens to stumble across this - I figured out what was wrong!

Basically, you need to also make sure you run the odinfmt script as well inside OLS as well as the build script. Once you do that, then the formatting should work.

I don't know why as the formatter otherwise worked fine in things like Emacs and Neovim without having run the script but in any case, if you happen to be stuck with that then that's probably all you need to do.