From 24056072566f775f044862b135c5377cd10b40d8 Mon Sep 17 00:00:00 2001 From: Rahul Garg Date: Thu, 22 Sep 2022 10:14:20 -1000 Subject: [PATCH 1/2] Add var-154 audit --- audit/var-154.md | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 audit/var-154.md diff --git a/audit/var-154.md b/audit/var-154.md new file mode 100644 index 000000000..8f80756d6 --- /dev/null +++ b/audit/var-154.md @@ -0,0 +1,35 @@ +# Chain Variable Transaction 154 + +## Changes + +This transaction sets `security_reward_bugfix` to `true` and +`validator_stale_heartbeat_check` to `true`. + +# Version threshold + +None + +## Transaction + +```erlang +[{1538069, + [{blockchain_txn_vars_v1_pb,[{blockchain_var_v1_pb,"security_reward_bugfix", + "atom",<<"true">>}, + {blockchain_var_v1_pb,"validator_stale_heartbeat_check", + "atom",<<"true">>}], + 0, + <<48,69,2,33,0,233,131,9,180,190,94,235,193,217,224,63,66, + 160,186,8,133,108,25,229,127,11,245,109,58,183,3,129,88, + 57,127,15,18,2,32,2,60,171,182,223,120,73,154,190,90,71, + 5,13,135,59,1,71,215,194,104,5,56,92,194,92,7,98,17,4, + 125,50,155>>, + <<>>,<<>>,[],[],154,[],[],[]}]}] +``` + +## Acceptance block + +1538069 + +## Acceptance block time + +Thu 22 Sep 20:05:51 UTC 2022 From 2e23b21e7cafafbc9c0aa23fa8cb82e4baf212ca Mon Sep 17 00:00:00 2001 From: Rahul Garg Date: Thu, 22 Sep 2022 10:40:40 -1000 Subject: [PATCH 2/2] Add rationale --- audit/var-154.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/audit/var-154.md b/audit/var-154.md index 8f80756d6..cdde43b2d 100644 --- a/audit/var-154.md +++ b/audit/var-154.md @@ -2,8 +2,11 @@ ## Changes -This transaction sets `security_reward_bugfix` to `true` and -`validator_stale_heartbeat_check` to `true`. +|Var | Old | New | Rationale | +|--------------------------------|----------|-------|-------------------------------------------------------| +|security_reward_bugfix |undefined |true | Ensure that security transfers use correct token_type | +|validator_stale_heartbeat_check |undefined |true | Ensure that validator heartbeats are not too old | + # Version threshold