Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder support for Map<String, String> as an option #8217

Closed
Tomas-Kraus opened this issue Jan 10, 2024 · 1 comment
Closed

Builder support for Map<String, String> as an option #8217

Tomas-Kraus opened this issue Jan 10, 2024 · 1 comment
Assignees
Labels
4.x Version 4.x config enhancement New feature or request
Milestone

Comments

@Tomas-Kraus
Copy link
Member

Tomas-Kraus commented Jan 10, 2024

It would be nice to have support for Config options like

  properties:
    eclipselink.target-database: MySQL
    eclipselink.target-server: None
    eclipselink.logging.level: FINEST
    eclipselink.logging.level.weaver: OFF
    eclipselink.logging.parameters: true
    eclipselink.weaving: false

to be provided using

    @Option.Configured
    Map<String, String> properties();

in the ConfigBlueprint.

Will require to modify TypeHandlerMap to process and return whole nodes subtree (including child nodes).

@Tomas-Kraus Tomas-Kraus added enhancement New feature or request config 4.x Version 4.x labels Jan 10, 2024
@Tomas-Kraus Tomas-Kraus added this to the 4.x milestone Jan 10, 2024
@Tomas-Kraus Tomas-Kraus self-assigned this Jan 10, 2024
@tomas-langer tomas-langer changed the title Support @ConfiguredOption(kind = ConfiguredOption.Kind.MAP) for names containing '.' Builder support for Map<String, String> as an option Jan 10, 2024
@tomas-langer
Copy link
Member

There is a method asMap() on Config
This should be generated as config.get("key").detach().asMap().orElseGet(Map::of)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x config enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants