Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helidon init does not produce app.yaml for 3.x.x #7882

Closed
DavideRossi opened this issue Oct 24, 2023 · 6 comments
Closed

Helidon init does not produce app.yaml for 3.x.x #7882

DavideRossi opened this issue Oct 24, 2023 · 6 comments

Comments

@DavideRossi
Copy link

It used to work (and it's also described in the quickstart).
For some reason now it only works when selecting version 4.0.0.
Creating a project with the Maven archetype does not work either (which I guess is what helidon init does under the hood) but I admit I did not try that in the past.

@tvallin
Copy link
Member

tvallin commented Oct 24, 2023

Indeed, this issue was reported and fixed under the Helidon repository: #7215

@DavideRossi
Copy link
Author

I see. Still does not work with the current version of helidon init when selecting a 3.x.x version. Is there a way to fix this behavior?

@tvallin
Copy link
Member

tvallin commented Oct 24, 2023

Yes, it will be included in the next 3.x Helidon release. Version 3.2.2 does not contain the fix

@DavideRossi
Copy link
Author

Yet there is something weird to my eyes.
Creating a 3.x.x project results in a missing app.yaml while creating a 4.0.0 project with very same version of the helidon cli does not. This seems to suggest that the helidon cli is using different revisions of archetypes/helidon/src/main/archetype/common/presets.xml depending on the chosen Helidon version.
And, if that is the case, why it "sees" a different preset.xml for 3.x.x than what it used to "see" a couple of versions ago (given that it used to create the app.yaml file)?

@romain-grecourt romain-grecourt transferred this issue from helidon-io/helidon-build-tools Oct 24, 2023
@romain-grecourt
Copy link
Contributor

romain-grecourt commented Oct 24, 2023

And, if that is the case, why it "sees" a different preset.xml for 3.x.x than what it used to "see" a couple of versions ago (given that it used to create the app.yaml file)?

Archetypes are released as part of the Maven release, the change was made in #4887 which was part of 3.0.2.

Before 3.0.2 app.yaml was (incorrectly) included by default. #4887 fixed the archetype to (among other things) honor the k8s input. The preset value wasn't changed to true which is why the app.yaml file is not included in >= 3.0.2.

The fix (#7216) will be included in the next release (3.2.3). I will close this issue once 3.2.3 is available.

@m0mus
Copy link
Contributor

m0mus commented Oct 30, 2023

Closing as fixed in 3.2.3

@m0mus m0mus closed this as completed Oct 30, 2023
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants