Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: MP quickstart archetype has unnecessary metrics dependencies #7700

Closed
barchetta opened this issue Oct 2, 2023 · 1 comment · Fixed by #7710
Closed

4.x: MP quickstart archetype has unnecessary metrics dependencies #7700

barchetta opened this issue Oct 2, 2023 · 1 comment · Fixed by #7710
Assignees
Labels
4.x Version 4.x archetypes bug Something isn't working
Milestone

Comments

@barchetta
Copy link
Member

  • Helidon Version: 4.0.0-RC1
  • Helidon MP

Problem Description

Generate a 4.0.0-RC1 MP quickstart using the CLI and the pom.xml has:

        <dependency>
            <groupId>io.helidon.metrics</groupId>
            <artifactId>helidon-metrics</artifactId>
            <scope>runtime</scope>
        </dependency>

And

        <dependency>
            <groupId>io.helidon.metrics</groupId>
            <artifactId>helidon-metrics</artifactId>
        </dependency>

I don't think it should have either of these.

@barchetta barchetta added archetypes 4.x Version 4.x labels Oct 2, 2023
@barchetta barchetta added this to the 4.0.0-RC2 milestone Oct 2, 2023
@barchetta barchetta added the bug Something isn't working label Oct 2, 2023
@tjquinno
Copy link
Member

tjquinno commented Oct 2, 2023

I believe Joe is correct here.

At one point we planned to use bundles such as helidon-metrics but, at least for now, we have moved away from that.

For MP, depending on helidon-microprofile-metrics and org.eclipse.microprofile.metrics:microprofile-metrics-api should be what we want for API dependencies. The MP QuickStart depends on the full Helidon MP bundle which includes those already.

And (as we've discussed earlier), these need to be present also:

        <dependency>
            <groupId>io.helidon.webserver.observe</groupId>
            <artifactId>helidon-webserver-observe-metrics</artifactId>
            <scope>runtime</scope>
        </dependency>
        <dependency>
            <groupId>io.helidon.metrics</groupId>
            <artifactId>helidon-metrics-system-meters</artifactId>
            <scope>runtime</scope>
        </dependency>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x archetypes bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants