Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of hibernate to 6.0.1.Final - so we can leverage various (performance) improvements #4188

Closed
jvissers opened this issue May 9, 2022 · 5 comments
Assignees
Labels
dependencies Pull requests that update a dependency file jpa/jta P3

Comments

@jvissers
Copy link

jvissers commented May 9, 2022

Environment Details

  • Helidon Version: 2.5.0
  • Helidon MP
  • JDK version: 17.0.2
  • OS: Ubuntu 22.04 LTS
  • Docker version (if applicable): n/a

Problem Description

Version 6.0.1.Final of Hibernate provides a number of performance improvements.
https://github.com/hibernate/hibernate-orm/blob/main/changelog.txt

In order to benefit from these improvements, Helidon MP should consider bumping the version to 6.0.1.Final

@barchetta barchetta added dependencies Pull requests that update a dependency file jpa/jta P3 labels May 12, 2022
@barchetta barchetta added this to the 2.5.1 milestone May 12, 2022
@ljnelson
Copy link
Member

We can't do this on the 2.x line; Hibernate 6 relies on Jakarta Persistence 3.0, which involves jakarta.persistence packages, not javax.persistence packages.

@jvissers
Copy link
Author

Ah - I see, that's unfortunate.

I actually checked the FAQ earlier and it points to the 3.0 specification: https://jakarta.ee/specifications/persistence/3.0/jakarta-persistence-spec-3.0.html

From there I took it that this potentially would be doable.

@ljnelson
Copy link
Member

ljnelson commented May 12, 2022

Perhaps we're talking past each other: Jakarta Persistence 3.0 features jakarta.persistence package names. Helidon 2.5.0 relies on Jakarta Persistence 2.2, which features javax.persistence package names. I'll change the FAQ information, which was written to be against our master branch, which will eventually become the Helidon 3.x line.

@barchetta barchetta removed this from the 2.5.1 milestone May 12, 2022
@jvissers
Copy link
Author

jvissers commented May 12, 2022

Perhaps we're talking past each other: Jakarta Persistence 3.0 features jakarta.persistence package names. Helidon 2.5.0 relies on Jakarta Persistence 2.2, which features javax.persistence package names. I'll change the FAQ information, which was written to be against our master branch, which will eventually become the Helidon 3.x line.

I guess we are the FAQ that I was referring to is from MP 2.5.0 and it points to 3.0.0 JPA. So that is confusing. The link in the FAQ should probably be updated.

@ljnelson
Copy link
Member

This is addressed in master with #4484.

@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file jpa/jta P3
Projects
Archived in project
Development

No branches or pull requests

3 participants