Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update:execute] returns exit code 1 when no updates available #3527

Closed
nvaken opened this issue Sep 20, 2017 · 2 comments
Closed

[update:execute] returns exit code 1 when no updates available #3527

nvaken opened this issue Sep 20, 2017 · 2 comments

Comments

@nvaken
Copy link
Contributor

nvaken commented Sep 20, 2017

I think update:execute should not return the same exit code as a failed update. I think this has been recently implemented since recently our deployment process crashes since update:execute now returns a non-0 exit code if there are no updates.

Arguably, it should return a dedicated exit code (eg. 2) so you can differentiate between failed or no updates. If a dedicated exit code is not possible, it should return 0 in my opinion; not updating Drupal does not mean it failed. Let us discuss.

Edit: Also, I'd suggest that "error" message is reduced to a "warning". My colleagues are startled by the big red error message while deploying new versions of projects. update:execute is part of our deployment process, regardless if there are new updates, in that case it feels wrong to show errors; nothing's gone wrong.

@jmolivas
Copy link
Member

jmolivas commented Sep 22, 2017

@nvaken Fixed with this PR #3518 you can apply this patch https://patch-diff.githubusercontent.com/raw/hechoendrupal/drupal-console/pull/3518.patch new release 1.1.0 will be tag next week during DrupalCon.

@nvaken
Copy link
Contributor Author

nvaken commented Sep 22, 2017

Awesome, looks like a good patch on first sight, I'll be using that.

@nvaken nvaken closed this as completed Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants