Backport CVE-2019-5421 fix to 3.x #5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backported from heartcombo#4996
tegon
reviewed
Mar 25, 2019
| initial_failed_attempts = user.failed_attempts | ||
| same_user = User.find(user.id) | ||
|
|
||
| user.valid_for_authentication?{ false } |
There was a problem hiding this comment.
Just out of curiosity, what's the benefit of calling #valid_for_authentication? instead of #user.increment_failed_attempts?
There was a problem hiding this comment.
Afaik increment_failed_attempts is not available in the 3-stable branch.
The incrementation is actually done in the valid_for_authentication? method
There was a problem hiding this comment.
Oh, that's correct. That's my bad, sorry 😞
|
is there a timeline for when this fix will be released? |
|
@dy-cs There are no plans to release a version since 3.x is not officially maintained anymore. We do accept those backport pull requests so that people can grab the Gem directly from GitHub pointing to the |
|
@tegon gotcha. thanks for the reply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4996