Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend Map: Remember zoom mode. Move viewport logic to useGraphViewport hook #2649

Merged
merged 3 commits into from
Dec 10, 2024
Merged

frontend Map: Remember zoom mode. Move viewport logic to useGraphViewport hook #2649

merged 3 commits into from
Dec 10, 2024

Conversation

sniok
Copy link
Contributor

@sniok sniok commented Dec 9, 2024

Remembers your last selected view mode

For example:
Click on fit to view on the map
Navigate around
It will now always fit to view (used to be fit to 100% by default)

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 9, 2024
@sniok sniok added frontend Issues related to the frontend resourceMap labels Dec 9, 2024
joaquimrocha
joaquimrocha requested changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly but I think these are two different commits:
Move viewport logic to useGraphView
Remember zoom mode

@sniok sniok requested a review from joaquimrocha December 10, 2024 14:22
@joaquimrocha joaquimrocha added this to the v0.27.0 milestone Dec 10, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 10, 2024
@joaquimrocha joaquimrocha merged commit b334efb into main Dec 10, 2024
17 of 18 checks passed
@joaquimrocha joaquimrocha deleted the map-zoom-mode branch December 10, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquimrocha joaquimrocha joaquimrocha approved these changes

Assignees
No one assigned
Labels
frontend Issues related to the frontend lgtm This PR has been approved by a maintainer resourceMap size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Release Plan / Roadmap
Status: Done
Milestone
v0.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sniok @joaquimrocha