Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Add snapshot test for window.pluginLib #2473

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

sniok
Copy link
Contributor

@sniok sniok commented Oct 24, 2024

This will make it easier to maintain compatibility with plugins by keeping track of what is in pluginLib object

This will make it easier to maintain compatibility with plugins by
keeping track of what is in pluginLib object

Signed-off-by: Oleksandr Dubenko <[email protected]>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 24, 2024
@sniok sniok requested a review from a team October 24, 2024 10:14
@sniok sniok added frontend Issues related to the frontend testing labels Oct 24, 2024
Copy link
Collaborator

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This allows us to better check for unintended backward compatibility breaks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 24, 2024
@joaquimrocha joaquimrocha merged commit 0979b16 into main Oct 24, 2024
18 checks passed
@joaquimrocha joaquimrocha deleted the pluginlib-test branch October 24, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues related to the frontend lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants