Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup Border Blends in With Background #22

Open
Zeklandia opened this issue Jan 2, 2014 · 1 comment
Open

Popup Border Blends in With Background #22

Zeklandia opened this issue Jan 2, 2014 · 1 comment

Comments

@Zeklandia
Copy link

The white border around popups blends in with white backgrounds. Either a shadow or a faint line around the outside would easily fix this.

@hdni
Copy link
Owner

hdni commented Jan 5, 2014

Assuming you mean the Shell popups, the way the Gnome team implemented shadows isn't really convenient to work with. Since Phosphene's popups have an arrow, the shadows end up being ugly or nonsensical. If I removed the arrows, it would be possible, but I'm a stubborn blockhead who thinks that those little triangles make more sense in this case.
I've considered adding a border — that's what I did for my other themes — but didn't do it because it would be inconsistent. All the other windows and popups are simply white, so I felt sheepish to add a border only for the popups, and I don't want to touch the rest because I'm pleased with it. Really, a shadow would be the best solution; that's what I did for the OSD and the notifications, as you've probably noticed.

Though you're right that it's a problem, so I'll leave the issue open and try to implement a solution that I'm pleased with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants