Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Killingtest can contain commas, breaking CSV export #1178

Closed
Bonajo opened this issue Mar 26, 2023 · 0 comments · Fixed by #1179
Closed

Killingtest can contain commas, breaking CSV export #1178

Bonajo opened this issue Mar 26, 2023 · 0 comments · Fixed by #1179

Comments

@Bonajo
Copy link
Contributor

Bonajo commented Mar 26, 2023

Summary

The method definition of killingTest can contain commas, in case the method has parameters.
These commas break CSV parsing, as they are interpreted as starting a new column.

Steps to reproduce

Simple example of code that will produce a breaking killinTest:

@ParameterizedTest
@CsvSource({
    "test,test",
})
public void testMethod(String parm1, String param2 ) {
    // code left out
}

This would generate the following definition for killingTest

testMethod(java.lang.String, java.lang.String)

Notice the comma.

What I expect to happen

That the method definition of the killingTest is quoted, as not to break CSV parsing.

What actually happens

The killingTest is written to the CSV report as-is, breaking CSV parsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant