Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reclaim FFmpeg thread resources when paused (maybe?) #22

Open
hbomb79 opened this issue Jun 5, 2023 · 0 comments
Open

Reclaim FFmpeg thread resources when paused (maybe?) #22

hbomb79 opened this issue Jun 5, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@hbomb79
Copy link
Owner

hbomb79 commented Jun 5, 2023

Open to debate whether or not this makes sense, but it's reasonable to assume a user may pause a transcode in order to get a different transcode to start, however currently the 'thread resources' are claimed when the transcode task begins, and they're only released when the task completes. This includes when the task is successful, cancelled, or troubled.

However, we may want to consider this behavior for paused transcodes too. It's not as trivial as the other three states as those don't need to actually keep any state around. A pause needs to carefully dance with the service to properly release threads on suspension and re-acquire threads before resuming (which could mean the task waits for many minutes/hours).
Currently the transcode service simply does not allow for this type of behavior, but anything is possible... it's just whether the complexity is worth it.

@hbomb79 hbomb79 added bug Something isn't working good first issue Good for newcomers labels Jun 5, 2023
@hbomb79 hbomb79 moved this to 🆕 New in Thea Roadmap Jun 5, 2023
@hbomb79 hbomb79 moved this from 📋 Backlog to 📋 Selected for Development in Thea Roadmap Jun 5, 2023
@hbomb79 hbomb79 changed the title Reclaim FFmpeg thread resources when paused or troubled Reclaim FFmpeg thread resources when paused (maybe?) Jan 6, 2024
@hbomb79 hbomb79 added this to the V1 milestone Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: 📋 Selected for Development
Development

No branches or pull requests

1 participant