Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout for discover in connect() #75

Closed
skjerns opened this issue Jun 13, 2019 · 2 comments
Closed

Timeout for discover in connect() #75

skjerns opened this issue Jun 13, 2019 · 2 comments
Assignees
@hbldh
Labels
Backend: pythonnet Issues or PRs relating to the .NET/pythonnet backend duplicate This issue or pull request already exists enhancement New feature or request

Comments

@skjerns
Copy link

skjerns commented Jun 13, 2019

  • bleak version: 0.4.2
  • Python version: 3.7
  • Operating System: Win10

Description

When connecting via DotNet backend, discover is called with a timeout of 2.0. However, this timeout is not always sufficient to get responses from the device necessary. In around 1/3rd of the cases it will not be able to connect to my device due to not finding it within 2 seconds.

Do you think that here a 'continue looking for device until found or timeout' loop would be useful? So the maximal timeout would be the default 5.0, but it can be shorter if the device is found before. Else, the connect method might have a parameter force that also tries to connect even if the device was not found during radio?
@hbldh
Copy link
Owner

hbldh commented Jun 24, 2019

Duplicate of #70.
This is fixed in 6daae16 and will be released in version 0.4.3 shortly.

@hbldh hbldh self-assigned this Jun 24, 2019
@hbldh hbldh added duplicate This issue or pull request already exists enhancement New feature or request Backend: pythonnet Issues or PRs relating to the .NET/pythonnet backend labels Jun 24, 2019
@hbldh hbldh closed this as completed in 9aebbb2 Jun 30, 2019
@hbldh
Copy link
Owner

hbldh commented Jul 1, 2019

Released 0.4.3 yesterday. Timeout keyword is now available in both BlueZ and .NET backend.

@Honusnap Honusnap mentioned this issue Jan 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hbldh hbldh

Labels
Backend: pythonnet Issues or PRs relating to the .NET/pythonnet backend duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hbldh @skjerns