-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to cmake and mumble-plugin-cpp, also OO rewrite #82
Comments
@hbeni I'm willing to invest some time on figuring this API out and maybe rewriting the plugin. From the little I've seen it looks a little more like what I'm used to working with. And I have a feeling it should be easier to maintain. I haven't used cmake on any of my projects yet, but if we do switch, let's make sure we can parallel build ;) Currently make -j4 fails. Not a big deal on such a small project though. So what do you say we keep the current codebase patched and in working order and work on the new one on the side till it's a seamless drop-in replacement? |
Good idea! |
Strictly speaking it is not a requirement for using the wrapper. However all its dependencies and all the internal macro-management is done via cmake. So if you chose to use it in a different way, then that would |
@mill-j It would also be cool to convert the radio code and other modules to objectoriented, btw. |
Certainly, that should be easier than the current structs. Not to mention much easier to document with doxygen. What do you want to call the new branch? |
Pick your name - I usually do include the issue number tough. |
Robert adviced us:
Additionally: We should refactor to use more OO structures to get rid of all the global variables and functions (ref #58)
The text was updated successfully, but these errors were encountered: