Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New keyboard shortcut to commit without pushing #59

Merged
merged 1 commit into from
May 21, 2024

Conversation

lightproof
Copy link
Contributor

Added a keyboard shortcut for commit only (now set to alt+shift+s by default), in addition to the already existing options. For those cases when Logseq is used with local git.

This partially takes care of #40, albeit manually.

Copy link

@EnderDobra EnderDobra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
An additional checkStatus() is needed after operations.commit() to update status indicator.

commit: debounce(async function () {
  hidePopup();
  await commit(true, `[logseq-plugin-git:commit] ${new Date().toISOString()}`);
  checkStatus();
}), 

@lightproof
Copy link
Contributor Author

An additional checkStatus() is needed

Done

Copy link

@EnderDobra EnderDobra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@haydenull please review.

@haydenull
Copy link
Owner

Thank you all for your efforts, sorry for the late reply.

@haydenull haydenull merged commit fc799b8 into haydenull:main May 21, 2024
github-actions bot pushed a commit that referenced this pull request May 21, 2024
# [1.6.0](v1.5.5...v1.6.0) (2024-05-21)

### Bug Fixes

* 🐛 release action error ([52d170b](52d170b))

### Features

* New keyboard shortcut to commit without pushing ([#59](#59)) ([fc799b8](fc799b8))
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants